Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755725AbYJOSKa (ORCPT ); Wed, 15 Oct 2008 14:10:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753244AbYJOSKQ (ORCPT ); Wed, 15 Oct 2008 14:10:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55970 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753042AbYJOSKO (ORCPT ); Wed, 15 Oct 2008 14:10:14 -0400 Date: Wed, 15 Oct 2008 11:09:24 -0700 From: Andrew Morton To: Alexey Dobriyan Cc: Arjan van de Ven , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@elte.hu, Evgeniy Polyakov Subject: Re: [PATCH] fastboot: Introduce an asynchronous function call mechanism Message-Id: <20081015110924.82135ec7.akpm@linux-foundation.org> In-Reply-To: <20081015175252.GA10600@x200.localdomain> References: <20081012194427.2e21c22e@infradead.org> <20081015014117.faff3a61.akpm@linux-foundation.org> <20081015075246.2e1610f3@infradead.org> <20081015095905.41219c9d.akpm@linux-foundation.org> <20081015175252.GA10600@x200.localdomain> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 32 On Wed, 15 Oct 2008 21:52:52 +0400 Alexey Dobriyan wrote: > On Wed, Oct 15, 2008 at 09:59:05AM -0700, Andrew Morton wrote: > > On Wed, 15 Oct 2008 07:52:46 -0400 Arjan van de Ven wrote: > > > > > On Wed, 15 Oct 2008 01:41:17 -0700 > > > Andrew Morton wrote: > > > > > +static int async_active = 0; > > > > > > > > ? > > > ok will add comment > > > > I was actually "?"ing at the "= 0". I thought that would be obvious > > but it's whizzed past two people so far :( > > Is there evidence that some gccs will not add such variable to .bss? It does get placed in bss. > Because "= 0;" is more readable. Only to someone who doesn't know anything about C. For the rest of us it is inconsistent, is a visual distraction and wastes space which would be better taken up by a comment explaining the variable's function (lol). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/