Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755790AbYJOThe (ORCPT ); Wed, 15 Oct 2008 15:37:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754042AbYJOTh0 (ORCPT ); Wed, 15 Oct 2008 15:37:26 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:35767 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbYJOThZ (ORCPT ); Wed, 15 Oct 2008 15:37:25 -0400 Date: Wed, 15 Oct 2008 15:37:16 -0400 From: Christoph Hellwig To: OGAWA Hirofumi Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bnaujok@sgi.com Subject: Re: [PATCH 6/6] vfs: add LOOKUP_RENAME_NEW intent Message-ID: <20081015193716.GA22707@infradead.org> References: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> <524881153e848f5f6f3426623.ps@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 22 On Wed, Oct 15, 2008 at 10:58:11PM +0900, OGAWA Hirofumi wrote: > > This adds LOOKUP_RENAME_NEW intent for lookup of rename destination. > > LOOKUP_RENAME_NEW is going to be used like LOOKUP_CREATE. But since > the destination of rename() can be existing directory entry, so it has a > difference. Although that difference doesn't matter in my usage, this > tells it to user of this intent. Is this for handling CI rename properly? Barry was looking into this, but i told him to hold off for a while - the lookup code is changing quite a bit because Al is trying to sort out the lookup intent mess and we hopefully will stop passing the nameidata to ->lookup soon. Also I think LOOKUP_RENAME_TARGET might be a little more descriptive than LOOKUP_RENAME_NEW. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/