Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755463AbYJOTlb (ORCPT ); Wed, 15 Oct 2008 15:41:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752212AbYJOTlX (ORCPT ); Wed, 15 Oct 2008 15:41:23 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:35800 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbYJOTlW (ORCPT ); Wed, 15 Oct 2008 15:41:22 -0400 Date: Wed, 15 Oct 2008 15:41:19 -0400 From: Christoph Hellwig To: OGAWA Hirofumi Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] vfs: add __d_instantiate() helper Message-ID: <20081015194119.GA24892@infradead.org> References: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 21 On Wed, Oct 15, 2008 at 10:58:10PM +0900, OGAWA Hirofumi wrote: > > This adds __d_instantiate() for users which is already taking > dcache_lock, and replace with it. > > The part of d_add_ci() isn't equivalent. But it should be needed > fsnotify_d_instantiate() actually, because the path is to add the > inode to negative dentry. fsnotify_d_instantiate() should be called > after change from negative to positive. > > __d_instantiate_unique() and d_materialise_unique() does opencoded > optimized version. From history, it seems a intent, so just add comment. Looks good, but I think those "optimized' version should also be converted, a single if shouldn't matter with todays branch predictors. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/