Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755574AbYJOURV (ORCPT ); Wed, 15 Oct 2008 16:17:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753342AbYJOURD (ORCPT ); Wed, 15 Oct 2008 16:17:03 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:39541 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbYJOURB (ORCPT ); Wed, 15 Oct 2008 16:17:01 -0400 From: OGAWA Hirofumi To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] vfs: remove unnecessary fsnotify_d_instantiate() References: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> <524881153e848f5f6f3426623.ps@mail.parknet.co.jp> <20081015194334.GB24892@infradead.org> Date: Thu, 16 Oct 2008 05:16:58 +0900 In-Reply-To: <20081015194334.GB24892@infradead.org> (Christoph Hellwig's message of "Wed, 15 Oct 2008 15:43:34 -0400") Message-ID: <878wsppq9x.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 19 Christoph Hellwig writes: > On Wed, Oct 15, 2008 at 10:58:11PM +0900, OGAWA Hirofumi wrote: >> >> This calls d_move(), so fsnotify_d_instantiate() is unnecessary like >> rename path. > > fsnotify_d_instantiate and fsnotify_d_move call into different inotify > functions. Did you verify that this really does the right thing? > (Sorry, not in a mood to look into idiotify code..) Yes. I checked it. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/