Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755849AbYJOUUj (ORCPT ); Wed, 15 Oct 2008 16:20:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754847AbYJOUUY (ORCPT ); Wed, 15 Oct 2008 16:20:24 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:36357 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbYJOUUX (ORCPT ); Wed, 15 Oct 2008 16:20:23 -0400 Date: Wed, 15 Oct 2008 16:20:19 -0400 From: Christoph Hellwig To: OGAWA Hirofumi Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] vfs: remove unnecessary fsnotify_d_instantiate() Message-ID: <20081015202019.GA28686@infradead.org> References: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> <524881153e848f5f6f3426623.ps@mail.parknet.co.jp> <20081015194334.GB24892@infradead.org> <878wsppq9x.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878wsppq9x.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 20 On Thu, Oct 16, 2008 at 05:16:58AM +0900, OGAWA Hirofumi wrote: > Christoph Hellwig writes: > > > On Wed, Oct 15, 2008 at 10:58:11PM +0900, OGAWA Hirofumi wrote: > >> > >> This calls d_move(), so fsnotify_d_instantiate() is unnecessary like > >> rename path. > > > > fsnotify_d_instantiate and fsnotify_d_move call into different inotify > > functions. Did you verify that this really does the right thing? > > (Sorry, not in a mood to look into idiotify code..) > > Yes. I checked it. Then the patch looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/