Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754679AbYJOUkP (ORCPT ); Wed, 15 Oct 2008 16:40:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752702AbYJOUkD (ORCPT ); Wed, 15 Oct 2008 16:40:03 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:43946 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbYJOUkA (ORCPT ); Wed, 15 Oct 2008 16:40:00 -0400 From: OGAWA Hirofumi To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Trond.Myklebust@netapp.com Subject: Re: [PATCH 3/6] vfs: add __d_instantiate() helper References: <7754d3f83e848f5f6f2326623.ps@mail.parknet.co.jp> <20081015194119.GA24892@infradead.org> Date: Thu, 16 Oct 2008 05:39:56 +0900 In-Reply-To: <20081015194119.GA24892@infradead.org> (Christoph Hellwig's message of "Wed, 15 Oct 2008 15:41:19 -0400") Message-ID: <87wsg9oan7.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 37 Christoph Hellwig writes: > On Wed, Oct 15, 2008 at 10:58:10PM +0900, OGAWA Hirofumi wrote: >> >> This adds __d_instantiate() for users which is already taking >> dcache_lock, and replace with it. >> >> The part of d_add_ci() isn't equivalent. But it should be needed >> fsnotify_d_instantiate() actually, because the path is to add the >> inode to negative dentry. fsnotify_d_instantiate() should be called >> after change from negative to positive. >> >> __d_instantiate_unique() and d_materialise_unique() does opencoded >> optimized version. From history, it seems a intent, so just add comment. > > Looks good, but I think those "optimized' version should also be > converted, a single if shouldn't matter with todays branch predictors. Me too. Trond, do you care the following convert? E.g. in d_materialise_unique(): from dentry->d_inode = NULL; goto found_lock; to __d_instantiate(dentry, NULL); goto found_lock; -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/