Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755857AbYJOWMW (ORCPT ); Wed, 15 Oct 2008 18:12:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753672AbYJOWMK (ORCPT ); Wed, 15 Oct 2008 18:12:10 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43647 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbYJOWMI (ORCPT ); Wed, 15 Oct 2008 18:12:08 -0400 Date: Wed, 15 Oct 2008 15:11:19 -0700 From: Andrew Morton To: Matthew Wilcox Cc: mingo@elte.hu, ying.huang@intel.com, linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de Subject: Re: [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h Message-Id: <20081015151119.493ea13f.akpm@linux-foundation.org> In-Reply-To: <20081014184718.GG15064@parisc-linux.org> References: <1223459070.5872.167.camel@yhuang-dev.sh.intel.com> <20081010144335.65d8153b.akpm@linux-foundation.org> <20081010214958.GA7708@elte.hu> <20081010155450.094288b4.akpm@linux-foundation.org> <20081014184718.GG15064@parisc-linux.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 33 On Tue, 14 Oct 2008 12:47:19 -0600 Matthew Wilcox wrote: > On Fri, Oct 10, 2008 at 03:54:50PM -0700, Andrew Morton wrote: > > I have a note here that Matthew has proposed a different way of doing > > all this. I don't immediately recall the details. > > > > Can we get a refresh on all of that please? > > I didn't remember either, but having just reviewed my inbox from August, > I said that all architectures basically use: > > typedef struct { volatile int counter; } atomic_t; > #ifdef CONFIG_64BIT > typedef struct { volatile long counter; } atomic64_t; > #endif > > and that should just be put in . > > Roman Zippel did me one better and suggested just putting it in types.h, > which works for me. OK. Or we could do the usual include/asm-generic/atomic_types.h and then architectures can choose to include that if it is appropriate. Anyway the good news is that this concept is an addition to rather than a replacement of this current patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/