Date: Wed, 15 Oct 2008 16:40:41 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bob Montgomery <bob.montgomery@hp.com>
cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       vojtech@suse.cz, chandru@in.ibm.com
Subject: Re: [PATCH] disable CPU side GART accesses
In-Reply-To: <1224107317.2215.238.camel@amd.troyhebe>
Message-ID: <alpine.LFD.2.00.0810151630050.3288@nehalem.linux-foundation.org>
References: <1224107317.2215.238.camel@amd.troyhebe>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1276
Lines: 30


On Wed, 15 Oct 2008, Bob Montgomery wrote:
> 
> This patch changes the initialization of the GART to set the DISGARTCPU
> bit in the GART Aperture Control Register (AMD64_GARTAPERTURECTL).
> Setting the bit prevents requests from the CPUs from accessing the
> GART.  In other words, CPU memory accesses to the aperture address
> range will not cause the GART to perform an address translation.
> The aperture area is currently being unmapped at the kernel level
> with set_memory_np() in gart_iommu_init to prevent accesses from the
> CPU [...]

Would this allow us to get rid of that particular hackup code sequence 
entirely? Or do we still need them for other chip versions etc?

Also, the whole iommu/gart thing seems to have a lot of people who have 
worked on it, are the right people cc'd? Pavel seems to have touched the 
code last, but it seems to be originally done by Andi and then with 
touches by DaveJ. 

I get the feeling that the people cc'd are kdump people, not iommu/gart 
people, which is a bit sad.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/