Message-ID: <48F685A3.1060804@cs.columbia.edu>
Date: Wed, 15 Oct 2008 20:06:59 -0400
From: Oren Laadan <orenl@cs.columbia.edu>
Organization: Columbia University
User-Agent: Thunderbird 2.0.0.16 (X11/20080707)
MIME-Version: 1.0
To: Cedric Le Goater <clg@fr.ibm.com>
CC: Dave Hansen <dave@linux.vnet.ibm.com>, jeremy@goop.org, arnd@arndb.de,
       containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
       linux-mm@kvack.org, Alexander Viro <viro@zeniv.linux.org.uk>,
       "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
       Thomas Gleixner <tglx@linutronix.de>, Andrey Mirkin <major@openvz.org>
Subject: Re: [RFC v6][PATCH 0/9] Kernel based checkpoint/restart
References: <1223461197-11513-1-git-send-email-orenl@cs.columbia.edu>	<20081009124658.GE2952@elte.hu> <1223557122.11830.14.camel@nimitz>	<20081009131701.GA21112@elte.hu> <1223559246.11830.23.camel@nimitz>	<20081009134415.GA12135@elte.hu> <1223571036.11830.32.camel@nimitz>	<20081010153951.GD28977@elte.hu> <48F30315.1070909@fr.ibm.com>	<1223916223.29877.14.camel@nimitz> <48F6092D.6050400@fr.ibm.com>
In-Reply-To: <48F6092D.6050400@fr.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2148
Lines: 54


Cedric Le Goater wrote:
> Dave Hansen wrote:
>> On Mon, 2008-10-13 at 10:13 +0200, Cedric Le Goater wrote:
>>> hmm, that's rather complex, because we have to take into account the 
>>> kernel stack, no ? This is what Andrey was trying to solve in his patchset 
>>> back in September :
>>>
>>>         http://lkml.org/lkml/2008/9/3/96
>>>
>>> the restart phase simulates a clone and switch_to to (not) restore the kernel 
>>> stack. right ? 
>> Do we ever have to worry about the kernel stack if we simply say that
>> tasks have to be *in* userspace when we checkpoint them. 
> 
> at a syscall boundary for example. that would make our life easier 
> definitely. 
> 

The ideal situation is never worry about kernel stack: either we catch
the task in user space or at a syscall boundary. This is taken care of
by freezing the tasks prior to checkpoint.

The one exception (and it is a tedious one !) are states in which the
task is already frozen by definition: any ptrace blocking point where
the tracee waits for the tracer to grant permission to proceed with
its execution. Another example is in vfork(), waiting for completion.

In both cases, there will be a kernel stack and we cannot avoid it.
The bad news is that it may be a bit tedious to restart these cases.
The good news, however, is that they are very well defined locations
with well defined semantics. So upon restart all that is needed is
to emulate the expected behavior had we not been checkpointed. This,
luckily, does not require rebuilding the kernel stack, but instead
some smart glue code for a finite set of special cases.

Oren.


> C.
> 
>> If a task is
>> in an uninterruptable wait state, I'm not sure it's safe to checkpoint
>> it anyway.
> 
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/