Date: Wed, 15 Oct 2008 17:23:51 -0700 (PDT)
Message-Id: <20081015.172351.96225000.davem@davemloft.net>
To: harvey.harrison@gmail.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org
Subject: Re: [PATCH] sparc64: Annotate pointers in PeeCeeI.c
From: David Miller <davem@davemloft.net>
In-Reply-To: <1224116119.5815.11.camel@brick>
References: <1224116119.5815.11.camel@brick>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 857
Lines: 21

From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 15 Oct 2008 17:15:19 -0700

> This has no functional changes, but annotates the code to make
> the endianness more clear.  In addition, removes some of the only
> users of cpu_to_le[16|32]p in the kernel.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Remind me what the problem is with cpu_to_{le,be}*()?

The interface names define a direction, which in this case is
"CPU endianness to BE/LE endianness".  And that is exactly
what is happening in the out*() routines.

This aids comprehension of the code and is quite useful IMHO.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/