Date: Wed, 15 Oct 2008 21:40:42 -0600
From: Alex Chiang <achiang@hp.com>
To: Tejun Heo <tj@kernel.org>
Cc: jeff@redhat.com, linux-ide@vger.kernel.org,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stop gcc warning about uninitialized 'dev' in
	ata_scsi_scan_host
Message-ID: <20081016034042.GA27621@ldl.fc.hp.com>
Mail-Followup-To: Alex Chiang <achiang@hp.com>, Tejun Heo <tj@kernel.org>,
	jeff@redhat.com, linux-ide@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
References: <20081015232505.GB9272@ldl.fc.hp.com> <48F6A2E7.5090005@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48F6A2E7.5090005@kernel.org>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1179
Lines: 33

* Tejun Heo <tj@kernel.org>:
> Alex Chiang wrote:
> > Shuts up gcc-3.4.5-glibc-2.3.6 when it complains of:
> > 
> > drivers/ata/libata-scsi.c: In function `ata_scsi_scan_host':
> > drivers/ata/libata-scsi.c:3225: warning: 'dev' might be used
> > uninitialized in this function
> > 
> > Signed-off-by: Alex Chiang <achiang@hp.com>
> 
> Nacked-by: Tejun Heo <tj@kernel.org>
> 
> Some gcc versions complain about sata_via, others complain
> about something else.  Some versions complain about some
> iterator usages while not complaining about others, but none of
> those complaints is actually wrong or dangerous.  I don't think
> adding = NULL whenever some version of gcc complains is the
> right approach.

Hm, ok.

I guess we don't want to sprinkle these around all over the place
just to solve cosmetic issues, which makes sense, but is there
some other approach we could take instead? Any suggestions? Or
just live with it?

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/