From: Roland Dreier <rdreier@cisco.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
       markus.t.metzger@gmail.com
Subject: Re: [rfc] x86, bts: improve X86_PTRACE_BTS help text
References: <20081015182902.A30726@sedona.ch.intel.com>
Date: Wed, 15 Oct 2008 23:57:23 -0700
In-Reply-To: <20081015182902.A30726@sedona.ch.intel.com> (Markus Metzger's
	message of "Wed, 15 Oct 2008 18:29:02 +0200")
Message-ID: <ada1vyhc9ik.fsf@cisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1479
Lines: 40

Thanks for improving the help text; it looks much better.

One comment:

 >  config X86_DS
 > -	bool "Debug Store support"
 > -	default y
 > -	help
 > -	  Add support for Debug Store.
 > -	  This allows the kernel to provide a memory buffer to the hardware
 > -	  to store various profiling and tracing events.
 > +	def_bool X86_PTRACE_BTS
 > +	depends on X86_DEBUGCTLMSR

using def_bool here to get this turned on if X86_PTRACE_BTS is set
doesn't seem scalable to more uses of X86_DS.  I would have thought that
having X86_PTRACE_BTS select X86_DS would make more sense.

Or are other users of X86_DS not planned?  In which case should there be
a separate X86_DS option at all?

 > +	  This adds a ptrace interface to the hardware's branch trace store.
 > +
 > +	  Debuggers may use it to collect an execution trace of the debugged
 > +	  application in order to answer the question 'how did I get here?'.
 > +	  Debuggers may trace user mode as well as kernel mode.
 > +
 > +	  Say Y unless there is no application development on this machine
 > +	  and you want to save a small amount of code size.

This looks much better -- someone like me could read this and make an
informed decision about the config option.

Thanks,
  Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/