Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447AbYJPG6c (ORCPT ); Thu, 16 Oct 2008 02:58:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752838AbYJPG6S (ORCPT ); Thu, 16 Oct 2008 02:58:18 -0400 Received: from mailbox2.myri.com ([64.172.73.26]:1795 "EHLO myri.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751654AbYJPG6R (ORCPT ); Thu, 16 Oct 2008 02:58:17 -0400 Message-ID: <48F6E54C.5010207@myri.com> Date: Thu, 16 Oct 2008 08:55:08 +0200 From: Brice Goglin User-Agent: Mozilla-Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: Dan Williams CC: David Miller , akpm@linux-foundation.org, tiwai@suse.de, linux-ext4@vger.kernel.org, netdev@vger.kernel.org, linux-ide@vger.kernel.org, bzolnier@gmail.com, marek.vasut@gmail.com, dwmw2@infradead.org, mark.fasheh@oracle.com, ralf@linux-mips.org, mchehab@infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, jesse.brandeburg@intel.com Subject: Re: powerpc allmodconfig References: <20081015213337.a99a9595.akpm@linux-foundation.org> <20081015.220247.262683261.davem@davemloft.net> <1224137292.26782.5.camel@dwillia2-linux.ch.intel.com> In-Reply-To: <1224137292.26782.5.camel@dwillia2-linux.ch.intel.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 39 Dan Williams wrote: > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote: > >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios': >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax' >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled': >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has' >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function) >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.) >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag': >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id' >>> >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in >> order to fix this, but he hasn't shown any signs of life. >> >> So I'll do it myself later tonight. :-/ >> >> > The following seems to fix this up... > > ---snip---> > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y > There's already a completely different fix queued in netdev patchworks (for myri10ge only right now, to be duplicated for Intel drivers). The idea is to stop having almost-unrelated drivers select each other directly, let people select which drivers they really want, and have Kconfig handle modules/builtin-stuff correctly. See http://patchwork.ozlabs.org/patch/4506/ Brice -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/