Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbYJPIWb (ORCPT ); Thu, 16 Oct 2008 04:22:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753870AbYJPIWK (ORCPT ); Thu, 16 Oct 2008 04:22:10 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:55777 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754920AbYJPIWH (ORCPT ); Thu, 16 Oct 2008 04:22:07 -0400 Date: Thu, 16 Oct 2008 11:21:57 +0300 From: Adrian Bunk To: Takashi Iwai Cc: Andrew Morton , Dan Williams , linux-ext4@vger.kernel.org, netdev@vger.kernel.org, linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz , marek.vasut@gmail.com, David Woodhouse , Mark Fasheh , Ralf Baechle , Mauro Carvalho Chehab , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: powerpc allmodconfig Message-ID: <20081016082157.GC23630@cs181140183.pp.htv.fi> References: <20081015213337.a99a9595.akpm@linux-foundation.org> <20081016073836.GB23630@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 53 On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote: > At Thu, 16 Oct 2008 10:38:36 +0300, > Adrian Bunk wrote: > > > > On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote: > > > At Wed, 15 Oct 2008 21:33:37 -0700, > > > Andrew Morton wrote: > > > > > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026) > > > > sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026) > > > > > > These are definitions of deprecated interfaces. > > > We can remove it in 2.6.29. If we don't want to be conservative, it > > > can be removed in 2.6.28, too. > > >... > > > > Since it's an in-kernel API there's no reason to keep it once there are > > no users left. > > Right. But, IMO, now is no suitable time. > A thing like API removal should have been tested in linux-next, and we > had plenty of time indeed for 2.6.28. >... A grep through the tree and one test compile that covers sound/soc/soc-dapm.c should be enough testing. And having it then in -next once should be enough to discover if someone wrongly added a new user. I have removed many functions in the kernel, and there isn't much that can go wrong - even adding a PCI ID to a driver has a bigger risk of introducing a regression. > thanks, > > Takashi cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/