DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references:x-google-sender-auth;
        b=heoaFYp6Khhqlx4VZLUmr4mgS3gU7f6c8T5ahxBZXypZ5JyqO4/bJf0aJUCVOiSnzq
         Eq7aa+ZV8K8R6EZ3gbCKAziGjPHvqhafx75R7gh7MBzZ+7kEmaSkI62DbzEWOH/lKobz
         RTgPM0OMgxPTqQtlN/2tZOAJZjqJR6ChkRx2M=
Message-ID: <386072610810160658i17ba05e0la6d2251fcb269f3d@mail.gmail.com>
Date: Thu, 16 Oct 2008 21:58:21 +0800
From: "Bryan Wu" <cooloney@kernel.org>
To: "Alan Cox" <alan@redhat.com>
Subject: Re: [PATCH 2/6] Blackfin Serial Driver: Add a debug function to serial driver.
Cc: gyang <graf.yang@analog.com>, "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
       linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
In-Reply-To: <20081015083811.GA21237@shell.devel.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1223891185-13924-1-git-send-email-cooloney@kernel.org>
	 <1223891185-13924-3-git-send-email-cooloney@kernel.org>
	 <20081014142701.72090868@lxorguk.ukuu.org.uk>
	 <1224037421.6284.40.camel@dyang>
	 <20081015083811.GA21237@shell.devel.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 25

On Wed, Oct 15, 2008 at 4:38 PM, Alan Cox <alan@redhat.com> wrote:
> On Wed, Oct 15, 2008 at 10:23:41AM +0800, gyang wrote:
>> We are making a SMP like patch to blackfin, cpu_relax() is replaced by a
>> data cache flush function which will count it to a per-cpu counter.
>> If this serial function is called too early, the per-cpu data area have
>> not been initialized, this call will cause crash.
>> So we'd like to use barrier() instead of cpu_relax().
>
> Can you split that out as a separate change and include the explanation in
> the patch then.
>
> Thanks
> Alan
>

I'll handle this and will resend the whole blackfin serial driver
patches again as well as Sonic updates some bug fixing recently.

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/