Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S291436AbSAaX4r>; Thu, 31 Jan 2002 18:56:47 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S291439AbSAaX4i>; Thu, 31 Jan 2002 18:56:38 -0500
Received: from mailrelay1.lrz-muenchen.de ([129.187.254.101]:11880 "EHLO
	mailrelay1.lrz-muenchen.de") by vger.kernel.org with ESMTP
	id <S291438AbSAaX4X>; Thu, 31 Jan 2002 18:56:23 -0500
Date: Fri, 1 Feb 2002 00:56:07 +0100 (CET)
From: Simon Richter <Simon.Richter@phobos.fachschaften.tu-muenchen.de>
To: James Simmons <jsimmons@transvirtual.com>
cc: <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amiga input api drivers
In-Reply-To: <Pine.LNX.4.10.10201311542370.5906-100000@www.transvirtual.com>
Message-Id: <Pine.LNX.4.33.0202010053520.14728-100000@phobos.fachschaften.tu-muenchen.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 31 Jan 2002, James Simmons wrote:

> > > +	scancode = scancode >> 1;	/* lowest bit is release bit */
> > > +	down = scancode & 1;

> > Shouldn't that be the other way 'round?

> I don't know. Anyone?

Me neither, this just looked weird to me, since this code is equivalent to

down = (scancode & 2) >> 1;
scancode = scancode >> 1;

and this is not what I'd expect from the comment. :-)

   Simon

-- 
GPG public key available from http://phobos.fs.tum.de/pgp/Simon.Richter.asc
 Fingerprint: DC26 EB8D 1F35 4F44 2934  7583 DBB6 F98D 9198 3292
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/