Date: Thu, 16 Oct 2008 12:25:02 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Jackson <mpfj@mimc.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip
Message-Id: <20081016122502.3ad6e958.akpm@linux-foundation.org>
In-Reply-To: <48EB5FA7.4080701@mimc.co.uk>
References: <48EB5FA7.4080701@mimc.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 22

On Tue, 07 Oct 2008 14:09:59 +0100
Mark Jackson <mpfj@mimc.co.uk> wrote:

> This patch adds support for the (I2C based) DS28CM00 ID chip.

Please run scritps/checkpatch.pl across the diff and consider the
various things which it reports.  Many of them are minor layout issues.
The lack of printk facility levels is a should-fix thing.


>        printk("adding ds28cm00 driver !!\n");

Remove the " !!" :)

Please also cc i2c@lm-sensors.org on version 2.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/