Message-ID: <48F7AFA0.1080100@inria.fr>
Date: Thu, 16 Oct 2008 23:18:24 +0200
From: Brice Goglin <Brice.Goglin@inria.fr>
User-Agent: Mozilla-Thunderbird 2.0.0.16 (X11/20080724)
MIME-Version: 1.0
To: Christoph Lameter <cl@linux-foundation.org>
CC: LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
       Andrew Morton <akpm@linux-foundation.org>,
       Nathalie Furmento <nathalie.furmento@labri.fr>
Subject: Re: [PATCH 4/5] mm: rework do_pages_move() to work on page_sized
 chunks
References: <48F3AD47.1050301@inria.fr> <48F3AE1D.3060208@inria.fr> <48F79B42.3070106@linux-foundation.org>
In-Reply-To: <48F79B42.3070106@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1007
Lines: 34

Christoph Lameter wrote:
>> +	err = -ENOMEM;
>> +	pm = kmalloc(PAGE_SIZE, GFP_KERNEL);
>> +	if (!pm)
>>     
>
> ok.... But if you need a page sized chunk then you can also do
> 	get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page 		sized
> allocations?
>   

Right. But why get_zeroed_page()? I don't think I need anything zeroed
(and I needed so, I would have to zero again between each chunk).

alloc_pages(order=0)+__free_pages() is probably good.

>> +		/* fill the chunk pm with addrs and nodes from user-space */
>> +		for (j = 0; j < chunk_nr_pages; j++) {
>>     
>
> j? So the chunk_start used to be i?
>   

The original "i" is somehow "chunk_start+j" now.

Thanks Christoph, I'll send an updated "4/5" patch in the next days.

Brice

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/