Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952AbYJQA1Q (ORCPT ); Thu, 16 Oct 2008 20:27:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752123AbYJQA07 (ORCPT ); Thu, 16 Oct 2008 20:26:59 -0400 Received: from ozlabs.org ([203.10.76.45]:52798 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbYJQA06 (ORCPT ); Thu, 16 Oct 2008 20:26:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18679.56239.74999.534588@cargo.ozlabs.ibm.com> Date: Fri, 17 Oct 2008 11:26:23 +1100 From: Paul Mackerras To: Mathieu Desnoyers Cc: Linus Torvalds , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Steven Rostedt , Peter Zijlstra , Thomas Gleixner , David Miller , benh@kernel.crashing.org, Ingo Molnar Subject: Re: [RFC patch 04/15] get_cycles() : powerpc64 HAVE_GET_CYCLES In-Reply-To: <20081016234656.055839676@polymtl.ca> References: <20081016232729.699004293@polymtl.ca> <20081016234656.055839676@polymtl.ca> X-Mailer: VM 8.0.9 under Emacs 22.2.1 (i486-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 22 Mathieu Desnoyers writes: > This patch selects HAVE_GET_CYCLES and makes sure get_cycles_barrier() and > get_cycles_rate() are implemented. [snip] > +static inline cycles_t get_cycles_rate(void) > +{ > + return CLOCK_TICK_RATE; > +} CLOCK_TICK_RATE is certainly wrong. You want ppc_tb_freq (declared in asm/time.h). Or tb_ticks_per_sec, since we seem to have two variables for exactly the same thing, for some reason. :) Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/