Date: Thu, 16 Oct 2008 22:21:08 -0700 (PDT)
Message-Id: <20081016.222108.13382080.davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: benh@kernel.crashing.org, rdreier@cisco.com,
       Geert.Uytterhoeven@sonycom.com, hpa@zytor.com,
       linux-kernel@vger.kernel.org, mingo@elte.hu, yhlu.kernel@gmail.com,
       akpm@linux-foundation.org
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.LFD.2.00.0810162109570.3438@nehalem.linux-foundation.org>
References: <alpine.LFD.2.00.0810162036510.3438@nehalem.linux-foundation.org>
	<20081016.210404.151891223.davem@davemloft.net>
	<alpine.LFD.2.00.0810162109570.3438@nehalem.linux-foundation.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 829
Lines: 21

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 16 Oct 2008 21:18:08 -0700 (PDT)

> I dunno. I'd certainly be perfectly happy with having the flags and 
> field_width be specified by the resource flags. eg
> 
> 	flags = ZEROPAD | SMALL;
> 	fieldwidth = (res->flags & IORESOURCE_IO) ? 4 : 8;
> 
> or something like that. But would it be acceptable to everybody?

I personally appreciate seeing the full 64-bit address on sparc64,
even for IORESOURCE_IO, and that's helped me debug resource
calculation bugs on more than one occasion in the past.

But that's just me :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/