Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469AbYJQK0O (ORCPT ); Fri, 17 Oct 2008 06:26:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752954AbYJQKZ6 (ORCPT ); Fri, 17 Oct 2008 06:25:58 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:33216 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbYJQKZ5 (ORCPT ); Fri, 17 Oct 2008 06:25:57 -0400 From: KOSAKI Motohiro To: miaox@cn.fujitsu.com Subject: Re: [PATCH] sched: fix the wrong mask_len Cc: kosaki.motohiro@jp.fujitsu.com, Ingo Molnar , Linux-Kernel In-Reply-To: <48F8664A.2000205@cn.fujitsu.com> References: <48F8664A.2000205@cn.fujitsu.com> Message-Id: <20081017192505.E242.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Fri, 17 Oct 2008 19:25:54 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 33 > If the NR_CPUS isn't a multiple of 32, we get a truncated string of sched > domains by catting /proc/schedstat. This is caused by the wrong mask_len. > > This patch fix it. > > Signed-off-by: Miao Xie > > --- > kernel/sched_stats.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/sched_stats.h b/kernel/sched_stats.h > index 8385d43..81365b3 100644 > --- a/kernel/sched_stats.h > +++ b/kernel/sched_stats.h > @@ -9,7 +9,7 @@ > static int show_schedstat(struct seq_file *seq, void *v) > { > int cpu; > - int mask_len = NR_CPUS/32 * 9; > + int mask_len = (NR_CPUS/32 + 1) * 9; > char *mask_str = kmalloc(mask_len, GFP_KERNEL); > DIV_ROUND_UP() is better? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/