Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbYJQO0r (ORCPT ); Fri, 17 Oct 2008 10:26:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754500AbYJQO0j (ORCPT ); Fri, 17 Oct 2008 10:26:39 -0400 Received: from nf-out-0910.google.com ([64.233.182.190]:18029 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754312AbYJQO0j (ORCPT ); Fri, 17 Oct 2008 10:26:39 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=qV/wBN67jTKK50EECgpXjSkIcyoLIZgWBJ4ij3zF04g+xKqwCEOckJ1HXLAwrwxpFV S/py6WrC17WY8tsIO/rkX2PAbd7PjBjh49qRs455nJKRUKPlze0QSFGTQIPXEqf+LbZK EMZwhm0VCcFV/nvJ6CY4YoY9xmVD1MxiAnKLQ= Date: Fri, 17 Oct 2008 15:26:10 +0100 From: =?utf-8?Q?Am=C3=A9rico?= Wang To: Rakib Mullick Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH] init: Properly placing noinline keyword. Message-ID: <20081017142610.GA19832@hack.voiplan.pt> References: <20081017141354.GA9242@x200.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 29 On Fri, Oct 17, 2008 at 08:17:33PM +0600, Rakib Mullick wrote: >On 10/17/08, Alexey Dobriyan wrote: >> On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote: >> > Here, noinline keyword should be placed between storage class and type. >> >> >> Why? >Because, scripts/checkpatch.pl warned with following warning: > ERROR: inline keyword should sit between storage class and type Well, 'noinline' is different from 'inline'. 'noinline' is defined as: #define noinline __attribute__((noinline)) in include/linux/compiler-gcc.h. But 'inline' is a _keyword_ defined by C standard. If checkpatch.pl complains about 'noinline', you should fix checkpatch.pl. :) -- "Sometimes the only way to stay sane is to go a little crazy." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/