Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757951AbYJQTmG (ORCPT ); Fri, 17 Oct 2008 15:42:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755712AbYJQTlw (ORCPT ); Fri, 17 Oct 2008 15:41:52 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:64111 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513AbYJQTlv (ORCPT ); Fri, 17 Oct 2008 15:41:51 -0400 Date: Fri, 17 Oct 2008 12:39:47 -0700 From: Joel Becker To: "Nicholas A. Bellinger" Cc: Greg KH , LKML , Linux-fsdevel , linux-scsi , "Linux-iSCSI.org Target Dev" , SCST-Devel , Alan Stern , Andrew Morton , Christoph Hellwig Subject: Re: [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source. Message-ID: <20081017193947.GC5633@mail.oracle.com> Mail-Followup-To: "Nicholas A. Bellinger" , Greg KH , LKML , Linux-fsdevel , linux-scsi , "Linux-iSCSI.org Target Dev" , SCST-Devel , Alan Stern , Andrew Morton , Christoph Hellwig References: <1224226555.5556.279.camel@haakon2.linux-iscsi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1224226555.5556.279.camel@haakon2.linux-iscsi.org> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.18 (2008-05-17) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 30 On Thu, Oct 16, 2008 at 11:55:55PM -0700, Nicholas A. Bellinger wrote: > Hi Joel, Greg and Co, > > Here is the the first working code for allowing configfs to handle > symlinks from sysfs struct kobject based code. Here is the commit: > passing struct kobject into generic target_core_mod subsystem plugins > for locating struct block_device and struct scsi_device.. NAK. As Greg said, this just doesn't work. Don't go down this path. Joel -- "I always thought the hardest questions were those I could not answer. Now I know they are the ones I can never ask." - Charlie Watkins Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/