DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=XaASzenMsOFcwUElC2eR/R4vZHS0gvkriF0WdjQ64pL/5k9VwW04Vxkv6Ga3DbS4AkPM2K23narpV+KhJibdoPIojATIeZO9TvFw9D6zvivsdGB2SYuOqYITzeNR06GhI5rodjTd4rwbKWMt8jpgGGQ0tQfulvr9uhreeLznk1E=  ;
From: David Brownell <david-b@pacbell.net>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls
Date: Fri, 17 Oct 2008 13:25:01 -0700
User-Agent: KMail/1.9.9
Cc: linux-kernel@vger.kernel.org,
       David Brownell <dbrownell@users.sourceforge.net>,
       "Steven A. Falco" <sfalco@harris.com>,
       Grant Likely <grant.likely@secretlab.ca>,
       Jean Delvare <khali@linux-fr.org>, David Miller <davem@davemloft.net>,
       i2c@lm-sensors.org, linuxppc-dev@ozlabs.org
References: <20081016171222.GA24812@oksana.dev.rtsoft.ru> <20081016171303.GE5515@oksana.dev.rtsoft.ru>
In-Reply-To: <20081016171303.GE5515@oksana.dev.rtsoft.ru>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200810171325.01729.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 573
Lines: 21

On Thursday 16 October 2008, Anton Vorontsov wrote:
> +???????if (of_gc->chip)
> +???????????????return of_gc->chip;
> +???????return &of_gc->gc;

presumably there's a reason not to

	of_gc->chip = &of_gc->gc;

when this gets set up, so this can always be a simple

	return of_gc->chip;

(and inlined)?  Needlessly complex...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/