Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbYJRTET (ORCPT ); Sat, 18 Oct 2008 15:04:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751163AbYJRTCv (ORCPT ); Sat, 18 Oct 2008 15:02:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:47202 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbYJRTCt (ORCPT ); Sat, 18 Oct 2008 15:02:49 -0400 Date: Sat, 18 Oct 2008 11:34:01 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, jejb@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Cornelia Huck Subject: [patch 03/17] Driver core: Fix cleanup in device_create_vargs(). Message-ID: <20081018183401.GD14035@suse.de> References: <20081018182721.521723254@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="driver-core-fix-cleanup-in-device_create_vargs.patch" In-Reply-To: <20081018183334.GA14035@suse.de> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 37 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Cornelia Huck commit 286661b3777897220ecfcd774bccc68a34667f39 upstream If device_register() in device_create_vargs() fails, the device must be cleaned up with put_device() (which is also fine on NULL) instead of kfree(). Signed-off-by: Cornelia Huck Signed-off-by: Greg Kroah-Hartman --- drivers/base/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1243,7 +1243,7 @@ struct device *device_create_vargs(struc return dev; error: - kfree(dev); + put_device(dev); return ERR_PTR(retval); } EXPORT_SYMBOL_GPL(device_create_vargs); -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/