Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbYJTIfr (ORCPT ); Mon, 20 Oct 2008 04:35:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751519AbYJTIfj (ORCPT ); Mon, 20 Oct 2008 04:35:39 -0400 Received: from gate.crashing.org ([63.228.1.57]:48402 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbYJTIfi (ORCPT ); Mon, 20 Oct 2008 04:35:38 -0400 Subject: Re: [PATCH] x86, ioremap: use %pR in printk From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Ingo Molnar Cc: Linus Torvalds , linux-kernel@vger.kernel.org, David Miller , linux-pci@vger.kernel.org, yhlu.kernel@gmail.com, Andrew Morton , Jesse Barnes In-Reply-To: <20081020071203.GB12131@elte.hu> References: <20081020040823.871BDDDDEC@ozlabs.org> <20081020071203.GB12131@elte.hu> Content-Type: text/plain Date: Mon, 20 Oct 2008 19:34:42 +1100 Message-Id: <1224491682.7654.135.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 35 On Mon, 2008-10-20 at 09:12 +0200, Ingo Molnar wrote: > * Benjamin Herrenschmidt wrote: > > > This converts things in drivers/pci to use %pR to printout the > > content of a struct resource instead of hand-casted %llx or > > other variants. > > > > Signed-off-by: Benjamin Herrenschmidt > > cool! > > Acked-by: Ingo Molnar > > there's also two places in arch/x86/mm/ioremap.c that could use this > straight away - see the (untested) patch below. No, you don't pass it a phys_addr_t or a resource_size_t, you pass it a struct resource * Now, I would have liked to have a way to print a resource_size_t (or phys_addr_t) but that's harder because we need pointers for the magic typechecking to work (among others). Maybe we could create a special format for a pointer-to-resource_size_t and pass &foo on callers but that's fishy... Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/