Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbYJTLyA (ORCPT ); Mon, 20 Oct 2008 07:54:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752146AbYJTLxn (ORCPT ); Mon, 20 Oct 2008 07:53:43 -0400 Received: from mercuryimc.plus.com ([80.229.200.144]:38781 "EHLO mimc.mimc.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752112AbYJTLxm (ORCPT ); Mon, 20 Oct 2008 07:53:42 -0400 Message-ID: <48FC6F18.6040809@mimc.co.uk> Date: Mon, 20 Oct 2008 12:44:24 +0100 From: Mark Jackson User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Alessandro Zummo CC: dbrownell@users.sourceforge.net, lkml , rtc-linux@googlegroups.com, spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH v2] Add Dallas DS1390 RTC chip References: <48FC442E.9070206@mimc.co.uk> <20081020114607.1b0299cb@i1501.lan.towertech.it> In-Reply-To: <20081020114607.1b0299cb@i1501.lan.towertech.it> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 28 Alessandro Zummo wrote: > On Mon, 20 Oct 2008 09:41:18 +0100 > Mark Jackson wrote: > >> +struct ds1390 { >> + struct rtc_device *rtc; >> + u8 buf[9]; /* cmd + 8 registers */ >> + u8 tx_buf[2]; >> + u8 rx_buf[2]; >> +}; >> + > > don't we still have too many buffers? Ah yes ... ooops !! > > the use of bin2bcd an bcd2bin (lowercase) would also be appreciated. > Will do. Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/