Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbYJTQjP (ORCPT ); Mon, 20 Oct 2008 12:39:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752022AbYJTQi7 (ORCPT ); Mon, 20 Oct 2008 12:38:59 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51953 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbYJTQi6 (ORCPT ); Mon, 20 Oct 2008 12:38:58 -0400 Date: Mon, 20 Oct 2008 09:37:52 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Roland Dreier , Andrew Morton , "David S. Miller" , Alan Cox , linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , "H. Peter Anvin" , David Howells Subject: Re: [announce] new tree: "fix all build warnings, on all configs" In-Reply-To: <20081018082209.GA24220@elte.hu> Message-ID: References: <20081017171139.GA1792@elte.hu> <20081017180523.GA11590@elte.hu> <20081017191202.GA5396@elte.hu> <20081018082209.GA24220@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 39 On Sat, 18 Oct 2008, Ingo Molnar wrote: > > thx, you are right - fixed it via the patch below. Hell no. The old code was correct. Your code is shit. And you didn't fix _anything_. > case 5: > *(int *)to = *(int *)from; > - *((short *)to + 3) = *((short *)from + 3); > + *((char *)(to + 3)) = *((char *)(from + 3)); > return to; Are you just making changes by randomly inserting and deleting characters until you don't see warnings? Or what? That thing is supposed to be a 5-byte memcpy. Not a "take a random byte from a random location and move it to another random location". That would be "randcpy()", not "memcpy()". I don't want to see obvious and shitty crap like this. I don't want to pull from people who write code with some "random walk" algorithm. F*ck me, what's wrong with you people? THAT CODE WAS NOT BUGGY. If it causes a warning, it is because SOME CALLER used a 5-byte memcpy() on something that gcc thought was just four bytes in size. Ingo, I'm not going to pull _anything_ from you. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/