Date: Mon, 20 Oct 2008 19:47:13 +0100 (BST)
From: Hugh Dickins <hugh@veritas.com>
To: Matt Mackall <mpm@selenic.com>
cc: Dave Airlie <airlied@redhat.com>, Keith Packard <keithp@keithp.com>,
       Eric Anholt <eric@anholt.net>, Nick Piggin <npiggin@suse.de>,
       David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Export tiny shmem_file_setup for DRM-GEM
In-Reply-To: <1224525754.4323.21.camel@calx>
Message-ID: <Pine.LNX.4.64.0810201939310.14915@blonde.site>
References: <Pine.LNX.4.64.0810191242220.22825@blonde.site>
 <1224525754.4323.21.camel@calx>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1487
Lines: 34

On Mon, 20 Oct 2008, Matt Mackall wrote:
> On Sun, 2008-10-19 at 12:52 +0100, Hugh Dickins wrote:
> > We're trying to keep the !CONFIG_SHMEM tiny-shmem.c (using ramfs without
> > swap) in synch with CONFIG_SHMEM shmem.c (and mpm is preparing patches
> > to combine them).  I was glad to see EXPORT_SYMBOL_GPL(shmem_file_setup)
> > go into shmem.c, but why not support DRM-GEM when !CONFIG_SHMEM too?
> > But caution says still depend on MMU, since !CONFIG_MMU is.. different.
> > 
> > Signed-off-by: Hugh Dickins <hugh@veritas.com>
> 
> Acked-by: Matt Mackall <mpm@selenic.com>

Thanks.

> 
> Hugh, what path do you usually take for upstreaming shmem bits and what
> path should I take with my unify patch?

I send them to Andrew (Cc linux-kernel and/or linux-mm, erratic which,
at best depending on what the area of interest is - there's not much
of interest to linux-mm in the case of this unification) to get their
airing in -mm until the next merge window.

You could do that, or were you expecting me to pick up what you had?
We can do it that way too if you prefer: as things stood, I think
you were intending to add a patch to remove that redundant function,
and another to remove CONFIG_TMPFS - but I can do them if you prefer.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/