Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbYJTVeS (ORCPT ); Mon, 20 Oct 2008 17:34:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753279AbYJTVeH (ORCPT ); Mon, 20 Oct 2008 17:34:07 -0400 Received: from gate.crashing.org ([63.228.1.57]:37705 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181AbYJTVeG (ORCPT ); Mon, 20 Oct 2008 17:34:06 -0400 Subject: Re: [PATCH] x86, ioremap: use %pR in printk From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Ingo Molnar Cc: Linus Torvalds , linux-kernel@vger.kernel.org, David Miller , linux-pci@vger.kernel.org, yhlu.kernel@gmail.com, Andrew Morton , Jesse Barnes In-Reply-To: <20081020113602.GA2697@elte.hu> References: <20081020040823.871BDDDDEC@ozlabs.org> <20081020071203.GB12131@elte.hu> <1224491682.7654.135.camel@pasglop> <20081020090502.GB31710@elte.hu> <20081020110018.GA24579@elte.hu> <1224501352.7654.141.camel@pasglop> <1224501768.7654.144.camel@pasglop> <20081020113143.GB14097@elte.hu> <20081020113602.GA2697@elte.hu> Content-Type: text/plain Date: Tue, 21 Oct 2008 08:33:35 +1100 Message-Id: <1224538415.7654.160.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 26 On Mon, 2008-10-20 at 13:36 +0200, Ingo Molnar wrote: > got rid of the brackets, see the patches below. > > One open question would be whether to set the width to 8 on 32-bit > platforms and 16 on 64-bit platforms - right now it's 8 on both. Since > this is specifically a 'physical address' thing it might make sense to > extend that on 64-bit systems. (although it's quite a bit of screen real > estate so i think the current width of 8 should be fine) A -lot- of 64-bit platforms (though not all of them) have most of their stuff still in the 32 bit space, especially when IO is concerned. Keeping it to 8 thus makes the output nicer on those, and as Linus mentioned before, it's not like we lose digits anyway. If you want, you can re-use the #ifdef/#define I did for resources and thus give archs the option to have a different default. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/