Date: Mon, 20 Oct 2008 14:52:07 -0700
From: Arjan van de Ven <arjan@infradead.org>
To: Dave Airlie <airlied@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Brandon Philips <bphilips@suse.de>, zhenyu.z.wang@intel.com,
       jbarnes@virtuousgeek.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel-agp: Avoid oops for G33 on 1MB stolen case
Message-ID: <20081020145207.15843ca6@infradead.org>
In-Reply-To: <1224539086.3656.6.camel@optimus>
References: <20081014225817.GA29267@plankton.lan>
	<20081020142130.5c46bd7e.akpm@linux-foundation.org>
	<1224539086.3656.6.camel@optimus>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1251
Lines: 36

On Tue, 21 Oct 2008 07:44:46 +1000
Dave Airlie <airlied@redhat.com> wrote:
> > +				printk(KERN_WARNING PFX
> > > +				       "Warning: G33 chipset
> > > with 1MB"
> > > +					" allocated. Older X.org
> > > Intel drivers"
> > > +					" will not work.\n");
> > > +				WARN_ON(1);
> > > +			}
> > >  			gtt_entries = MB(1) - KB(size);
> > >  			break;
> > >  		case I855_GMCH_GMS_STOLEN_4M:
> > 
> > Is the bug which this patch addresses present in the 2.6.27 kernel?
> > 
> 
> I've been a bit wary about this patch, but on re-review I suppose it
> should be fine. We'll just get WARN_ONs in places we don't really want
> them, and I'm sure Arjan will come complaining about them from
> kerneloops.
> 

the patch is not so nice for this;
the printk+WARN_ON() really should be using WARN() instead; that also
allows me to filter these guys out easily if needed.

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/