Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754811AbYJTXtV (ORCPT ); Mon, 20 Oct 2008 19:49:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751209AbYJTXtJ (ORCPT ); Mon, 20 Oct 2008 19:49:09 -0400 Received: from gate.crashing.org ([63.228.1.57]:40308 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbYJTXtG (ORCPT ); Mon, 20 Oct 2008 19:49:06 -0400 Subject: Re: [PATCH] ibm_newemac: Fix new MAL feature handling From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Josh Boyer Cc: Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Jeff Garzik In-Reply-To: <20081016143840.GA29805@yoda.jdub.homelinux.org> References: <20081015213337.a99a9595.akpm@linux-foundation.org> <1224133010.8157.543.camel@pasglop> <20081016143840.GA29805@yoda.jdub.homelinux.org> Content-Type: text/plain Date: Tue, 21 Oct 2008 10:43:41 +1100 Message-Id: <1224546221.7654.196.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 37 On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote: > On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: > >> drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': > >> drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri' > >> drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function) > >> drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once > >> drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.) > >> drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri' > >> drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob': > >> drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function) > > > >That's annoying, I'll have a look. > > Support for new features needed by the PPC 405EZ boards > introduced some errors in the MAL and EMAC feature handling. > This broke 'allmodconfig' builds as CONFIG_PPC_DCR_NATIVE is > not set for those. > > This patch fixes these errors by wrapping the code in the > appropriate #ifdefs. > > Signed-off-by: Josh Boyer Acked-by: Benjamin Herrenschmidt --- Jeff, this breaks build, I'll put it in powerpc.git for a merge today, Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/