Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbYJTXxQ (ORCPT ); Mon, 20 Oct 2008 19:53:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752084AbYJTXxA (ORCPT ); Mon, 20 Oct 2008 19:53:00 -0400 Received: from g1t0028.austin.hp.com ([15.216.28.35]:25606 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbYJTXxA (ORCPT ); Mon, 20 Oct 2008 19:53:00 -0400 Date: Mon, 20 Oct 2008 17:52:58 -0600 From: Alex Chiang To: ebiederm@xmission.com, oomichi@mxs.nes.nec.co.jp, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tony.luck@intel.com Subject: Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core Message-ID: <20081020235258.GH15771@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , ebiederm@xmission.com, oomichi@mxs.nes.nec.co.jp, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tony.luck@intel.com References: <20081020233438.GG15771@ldl.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081020233438.GG15771@ldl.fc.hp.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 48 Oh whoops, I see that Tony Luck already sent a patch for this directly to Linus. [Sorry for the noise, but I didn't realize this until I decided to browse through my lkml folder, as Tony's patch hasn't been pushed out yet.] /ac * Alex Chiang : > Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add > vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the > ia64 build in this fashion: > > kernel/kexec.c: In function `crash_save_vmcoreinfo_init': > kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function) > kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once > kernel/kexec.c:1374: error: for each function it appears in.) > kernel/kexec.c:1410: error: dereferencing pointer to incomplete type > make[1]: *** [kernel/kexec.o] Error 1 > > Adding the proper include fixes the build. > > Signed-off-by: Alex Chiang > --- > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 777ac45..ac0fde7 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include > #include > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/