Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbYJUFSZ (ORCPT ); Tue, 21 Oct 2008 01:18:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751489AbYJUFSL (ORCPT ); Tue, 21 Oct 2008 01:18:11 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:53390 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbYJUFSK (ORCPT ); Tue, 21 Oct 2008 01:18:10 -0400 Message-ID: <48FD65F0.9070000@pobox.com> Date: Tue, 21 Oct 2008 01:17:36 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: benh@kernel.crashing.org CC: Josh Boyer , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] ibm_newemac: Fix new MAL feature handling References: <20081015213337.a99a9595.akpm@linux-foundation.org> <1224133010.8157.543.camel@pasglop> <20081016143840.GA29805@yoda.jdub.homelinux.org> <1224546221.7654.196.camel@pasglop> In-Reply-To: <1224546221.7654.196.camel@pasglop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 35 Benjamin Herrenschmidt wrote: > On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote: >> On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: >>>> drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': >>>> drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function 'mtdcri' >>>> drivers/net/ibm_newemac/mal.c:284: error: 'SDR0' undeclared (first use in this function) >>>> drivers/net/ibm_newemac/mal.c:284: error: (Each undeclared identifier is reported only once >>>> drivers/net/ibm_newemac/mal.c:284: error: for each function it appears in.) >>>> drivers/net/ibm_newemac/mal.c:285: error: implicit declaration of function 'mfdcri' >>>> drivers/net/ibm_newemac/mal.c: In function 'mal_rxeob': >>>> drivers/net/ibm_newemac/mal.c:302: error: 'SDR0' undeclared (first use in this function) >>> That's annoying, I'll have a look. >> Support for new features needed by the PPC 405EZ boards >> introduced some errors in the MAL and EMAC feature handling. >> This broke 'allmodconfig' builds as CONFIG_PPC_DCR_NATIVE is >> not set for those. >> >> This patch fixes these errors by wrapping the code in the >> appropriate #ifdefs. >> >> Signed-off-by: Josh Boyer > > Acked-by: Benjamin Herrenschmidt > --- > > Jeff, this breaks build, I'll put it in powerpc.git for a merge today, ACK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/