Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbYJUHR0 (ORCPT ); Tue, 21 Oct 2008 03:17:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752525AbYJUHQu (ORCPT ); Tue, 21 Oct 2008 03:16:50 -0400 Received: from mtagate5.de.ibm.com ([195.212.29.154]:47754 "EHLO mtagate5.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbYJUHQt (ORCPT ); Tue, 21 Oct 2008 03:16:49 -0400 Message-ID: <48FD81B8.5030103@fr.ibm.com> Date: Tue, 21 Oct 2008 09:16:08 +0200 From: Cedric Le Goater User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Li Zefan CC: Andrew Morton , Linux Containers , LKML Subject: Re: [PATCH 3/4] freezer_cg: use thaw_process() in unfreeze_cgroup() References: <48FD26F5.1070809@cn.fujitsu.com> <48FD273F.3040505@cn.fujitsu.com> <48FD2784.30906@cn.fujitsu.com> In-Reply-To: <48FD2784.30906@cn.fujitsu.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1868 Lines: 63 Li Zefan wrote: > Don't duplicate the implementation of thaw_process(). looks OK but you should remove __thaw_process() which is unused now. thanks, C. > Signed-off-by: Li Zefan > --- > kernel/cgroup_freezer.c | 15 ++++----------- > 1 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c > index 6fadafe..3ea57e4 100644 > --- a/kernel/cgroup_freezer.c > +++ b/kernel/cgroup_freezer.c > @@ -275,25 +275,18 @@ static int try_to_freeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) > return num_cant_freeze_now ? -EBUSY : 0; > } > > -static int unfreeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) > +static void unfreeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) > { > struct cgroup_iter it; > struct task_struct *task; > > cgroup_iter_start(cgroup, &it); > while ((task = cgroup_iter_next(cgroup, &it))) { > - int do_wake; > - > - task_lock(task); > - do_wake = __thaw_process(task); > - task_unlock(task); > - if (do_wake) > - wake_up_process(task); > + thaw_process(task); > } > cgroup_iter_end(cgroup, &it); > - freezer->state = CGROUP_THAWED; > > - return 0; > + freezer->state = CGROUP_THAWED; > } > > static int freezer_change_state(struct cgroup *cgroup, > @@ -320,7 +313,7 @@ static int freezer_change_state(struct cgroup *cgroup, > } > /* state == FREEZING and goal_state == THAWED, so unfreeze */ > case CGROUP_FROZEN: > - retval = unfreeze_cgroup(cgroup, freezer); > + unfreeze_cgroup(cgroup, freezer); > break; > default: > break; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/