Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbYJUIke (ORCPT ); Tue, 21 Oct 2008 04:40:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751739AbYJUIk1 (ORCPT ); Tue, 21 Oct 2008 04:40:27 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:62548 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751328AbYJUIk0 (ORCPT ); Tue, 21 Oct 2008 04:40:26 -0400 Message-ID: <48FD9570.8080406@cn.fujitsu.com> Date: Tue, 21 Oct 2008 16:40:16 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Cedric Le Goater CC: Andrew Morton , Linux Containers , LKML Subject: Re: [PATCH 3/4] freezer_cg: use thaw_process() in unfreeze_cgroup() References: <48FD26F5.1070809@cn.fujitsu.com> <48FD273F.3040505@cn.fujitsu.com> <48FD2784.30906@cn.fujitsu.com> <48FD81B8.5030103@fr.ibm.com> In-Reply-To: <48FD81B8.5030103@fr.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 15 Cedric Le Goater wrote: > Li Zefan wrote: >> Don't duplicate the implementation of thaw_process(). > > looks OK but you should remove __thaw_process() which is unused > now. > Then I'll make it a static function and remove the declaration from .h file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/