Date: Tue, 21 Oct 2008 13:34:56 +0200
From: Ingo Molnar <mingo@elte.hu>
To: David John <davidjon@xenontk.org>
Cc: akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
       linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com,
       tglx@linutronix.de, andi@firstfloor.org
Subject: Re: [PATCH v5] HPET: Remove the BKL.
Message-ID: <20081021113456.GA14529@elte.hu>
References: <1224568707-2361-1-git-send-email-davidjon@xenontk.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1224568707-2361-1-git-send-email-davidjon@xenontk.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 865
Lines: 23


* David John <davidjon@xenontk.org> wrote:

> Remove calls to the BKL as concurrent access is protected
> by the spinlock hpet_lock.
> 
> Signed-off-by: David John <davidjon@xenontk.org>
> ---
>  drivers/char/hpet.c |   41 ++++++++++++++++++++++++-----------------
>  1 files changed, 24 insertions(+), 17 deletions(-)

this patch still needs to add locking documentation commits to hpet.c, 
which shows that you considered all the locking changes that happen due 
to dropping the BKL. Most of this code runs very rarely so there's 
little chance that races will be caught in practice in any debuggable 
manner.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/