From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andi Kleen <andi@firstfloor.org>
Subject: Re: [announce] new tree: "fix all build warnings, on all configs"
Date: Tue, 21 Oct 2008 21:39:38 +0200
User-Agent: KMail/1.9.9
Cc: Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       "David S. Miller" <davem@davemloft.net>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       David Howells <dhowells@redhat.com>
References: <20081017171139.GA1792@elte.hu> <20081021111716.GA4476@elte.hu> <20081021120720.GG12825@one.firstfloor.org>
In-Reply-To: <20081021120720.GG12825@one.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810212139.39470.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1244
Lines: 35

On Tuesday, 21 of October 2008, Andi Kleen wrote:
> On Tue, Oct 21, 2008 at 01:17:16PM +0200, Ingo Molnar wrote:
> > 
> > * Andi Kleen <andi@firstfloor.org> wrote:
> > 
> > > >   *	acpi_pm_disable_gpes - Disable the GPEs.
> > > >   */
> > > > -static int acpi_pm_disable_gpes(void)
> > > > +static inline int acpi_pm_disable_gpes(void)
> > > 
> > > Just to satisfy my curiosity, what compiler warning does marking 
> > > functions inline fix?
> > 
> > the commit log below explains the situation. The warning exposed a maze 
> > of #ifdefs in drivers/acpi/sleep/main.c. It's not the warning we need to 
> > "fix" but that maze, obviously.
> 
> Thanks. That makes sense, 
> 
> I also agree with you that the better alternative would be 
> to just always force SUSPEND together with ACPI.
> 
> I suspect the code delta wouldn't be very large compared to the rest
> of the ACPI code.

Is that _really_ necessary?

I mean, do the warnings appear in any case that's not theoretically impossible?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/