Message-ID: <48FEA037.4050007@embeddedalley.com>
Date: Tue, 21 Oct 2008 23:38:31 -0400
From: Matthew Ranostay <mranostay@embeddedalley.com>
Organization: Embedded Alley Solutions Inc
User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
MIME-Version: 1.0
To: Harvey Harrison <harvey.harrison@gmail.com>
CC: Takashi Iwai <tiwai@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: correct bracketing in spdif test
References: <1224646084.5768.9.camel@brick>
In-Reply-To: <1224646084.5768.9.camel@brick>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1158
Lines: 32

Harvey Harrison wrote:
> Noticed by sparse:
> sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
>  sound/pci/hda/patch_sigmatel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a2ac720..788fdc6 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
>  			return err;
>  		spec->multiout.share_spdif = 1;
>  	}
> -	if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> +	if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
>  		err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
>  		if (err < 0)
>  			return err;

Thanks for finding this.


Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/