Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbYJVGCV (ORCPT ); Wed, 22 Oct 2008 02:02:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751446AbYJVGCL (ORCPT ); Wed, 22 Oct 2008 02:02:11 -0400 Received: from ns2.suse.de ([195.135.220.15]:49678 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbYJVGCL (ORCPT ); Wed, 22 Oct 2008 02:02:11 -0400 Date: Wed, 22 Oct 2008 08:02:09 +0200 Message-ID: From: Takashi Iwai To: Harvey Harrison Cc: Matthew Ranostay , LKML Subject: Re: [PATCH] sound: correct bracketing in spdif test In-Reply-To: <48FEA037.4050007@embeddedalley.com> References: <1224646084.5768.9.camel@brick> <48FEA037.4050007@embeddedalley.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 39 At Tue, 21 Oct 2008 23:38:31 -0400, Matthew Ranostay wrote: > > Harvey Harrison wrote: > > Noticed by sparse: > > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y > > > > Signed-off-by: Harvey Harrison > > --- > > sound/pci/hda/patch_sigmatel.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c > > index a2ac720..788fdc6 100644 > > --- a/sound/pci/hda/patch_sigmatel.c > > +++ b/sound/pci/hda/patch_sigmatel.c > > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec) > > return err; > > spec->multiout.share_spdif = 1; > > } > > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) { > > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) { > > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid); > > if (err < 0) > > return err; > > Thanks for finding this. > > > Acked-by: Matthew Ranostay Applied now. Thanks! Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/