Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754278AbYJVHD0 (ORCPT ); Wed, 22 Oct 2008 03:03:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752024AbYJVHDR (ORCPT ); Wed, 22 Oct 2008 03:03:17 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:57626 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbYJVHDR (ORCPT ); Wed, 22 Oct 2008 03:03:17 -0400 Date: Wed, 22 Oct 2008 09:03:12 +0200 From: Ingo Molnar To: Rakib Mullick Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.com, Andrew Morton Subject: Re: [PATCH -mm] ftrace : Fix section mismatch warning. Message-ID: <20081022070312.GA24749@elte.hu> References: <20081020162756.GA31201@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081020162756.GA31201@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 42 * Ingo Molnar wrote: > > * Rakib Mullick wrote: > > > WARNING: arch/x86/kernel/built-in.o(.text+0x11b41): Section mismatch > > in reference from the variable ftrace_test_p6nop to the function > > .init.text:ftrace_dyn_arch_init() > > The function ftrace_test_p6nop() references > > the function __init ftrace_dyn_arch_init(). > > This is often because ftrace_test_p6nop lacks a __init > > annotation or the annotation of ftrace_dyn_arch_init is wrong. > > > > WARNING: arch/x86/kernel/built-in.o(.text+0x11b4b): Section mismatch > > in reference from the variable ftrace_test_nop5 to the function > > .init.text:ftrace_dyn_arch_init() > > The function ftrace_test_nop5() references > > the function __init ftrace_dyn_arch_init(). > > This is often because ftrace_test_nop5 lacks a __init > > annotation or the annotation of ftrace_dyn_arch_init is wrong. > > > > This patch fixes the above warnings. Introduced by > > 'linux-next.patch'(2.6.27-rc5-mm1-broken-out). > > Thanks. > > > > Signed-off-by: Md.Rakib H. Mullick(rakib.mullick@gmail.com) > > applied to tip/tracing/urgent, thanks! actually, this patch is wrong: the problem highlighted in that warning is that ftrace_test_p6nop is non-__init while ftrace_dyn_arch_init() is __init. So the proper solution is to mark ftrace_test_p6nop init as well. (it's an assembly label so thus slightly more complex than usual, but doable.) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/