Date: Wed, 22 Oct 2008 09:31:41 +0100
From: Andy Whitcroft <apw@shadowen.org>
To: penguin-kernel@i-love.sakura.ne.jp
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: */ in string confuses checkpatch.pl
Message-ID: <20081022083141.GB22344@brain>
References: <200810210057.m9L0vQ7i012829@www262.sakura.ne.jp> <20081022075617.GA22344@brain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081022075617.GA22344@brain>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1481
Lines: 42

On Wed, Oct 22, 2008 at 08:56:17AM +0100, Andy Whitcroft wrote:
> On Tue, Oct 21, 2008 at 09:57:26AM +0900, penguin-kernel@i-love.sakura.ne.jp wrote:
> > Hello.
> > 
> > The below code confuses checkpatch.pl ver 0.21.
> > 
> > Regards.
> > ----------
> > # cat /tmp/foo.c
> > void foo(void)
> > {
> > 	bar(\" /proc/\\\\*/\");
> > 	bar(\" /proc/\\\\$/\");
> > }
> > # /usr/src/vanilla/linux-2.6.27.2/scripts/checkpatch.pl --file /tmp/foo.c
> > ERROR: need consistent spacing around \'/\' (ctx:WxV)
> > #4: FILE: tmp/foo.c:4:
> > +       bar(\" /proc/\\\\$/\");
> >               ^
> > 
> > total: 1 errors, 0 warnings, 5 lines checked
> > 
> > /tmp/foo.c has style problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.

Ok, I can see whats happened here.  Most of these \'s are extraneous.
Without those I can reproduce this.  Its a bug in the 'comment is open
at the start of hunk' detection.  I think I have updated this heuristic
to cope wit this.  Could you try your original patch (I assume there was
one) with the version below:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

Thanks for your report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/