Date: Wed, 22 Oct 2008 10:00:45 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tilman Schmidt <tilman@imap.cc>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
       Hansjoerg Lipp <hjlipp@web.de>
Subject: Re: [PATCH 72/80] tty: fix up gigaset a bit
Message-ID: <20081022100045.2f06e977@lxorguk.ukuu.org.uk>
In-Reply-To: <48FB27F1.9010007@imap.cc>
References: <20081013092758.21645.2359.stgit@localhost.localdomain>
	<20081013094438.21645.30934.stgit@localhost.localdomain>
	<48F762CA.4080608@imap.cc>
	<20081017124004.64d3f2cf@lxorguk.ukuu.org.uk>
	<48FB27F1.9010007@imap.cc>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 883
Lines: 19

> additional test_bit(TTY_IO_ERROR, &tty->flags) would catch a case that
> would otherwise be handled incorrectly?

Fiddling with tty->disc_data by hand probably currently does the right
thing. I don't guarantee it will continue to do so after the BKL removal
gets to ldisc setting.

> So I think removing the poll method is the right thing to do. If you
> have no objections, I'll submit a patch doing just that. (Hoping to
> still make it for the .28 merge window.)

If you really don't need the poll then it can go - for 2.6.29. The
current code isn't wrong on a functional level it just returns unexpected
results in the unplug case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/