Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbYJVMqz (ORCPT ); Wed, 22 Oct 2008 08:46:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751771AbYJVMqq (ORCPT ); Wed, 22 Oct 2008 08:46:46 -0400 Received: from vsmtp04.dti.ne.jp ([202.216.231.139]:62340 "EHLO vsmtp04.dti.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbYJVMqq (ORCPT ); Wed, 22 Oct 2008 08:46:46 -0400 From: hooanon05@yahoo.co.jp Subject: Re: __vm_enough_memory(), OVERCOMMIT_NEVER, current->mm, kernel thread To: Alan Cox Cc: linux-kernel@vger.kernel.org In-Reply-To: <20081022130926.44540b03@lxorguk.ukuu.org.uk> References: <7123.1224602071@jrobl> <20081021164619.341f01d9@lxorguk.ukuu.org.uk> <6775.1224630654@jrobl> <20081022092736.2a0795d1@lxorguk.ukuu.org.uk> <6689.1224674779@jrobl> <20081022130926.44540b03@lxorguk.ukuu.org.uk> Date: Wed, 22 Oct 2008 21:46:32 +0900 Message-ID: <6920.1224679592@jrobl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 22 Alan Cox: > This is the patch I propose: ::: > We could simply check for NULL and skip the modifier but we've caught other > real bugs in the past from mm being NULL here - cases where we did need a > valid mm set up (eg the exec bug about a year ago). OK. I didn't know there was an actual bug but now I understand why you want to insert WARN_ON(). I have nothing to say about your patch. Thank you Junjiro R. Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/