Date: Wed, 22 Oct 2008 16:13:54 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Glauber Costa <glommer@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
       "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register
Message-ID: <20081022141354.GA26372@elte.hu>
References: <20081022140009.GA9639@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081022140009.GA9639@localhost>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 872
Lines: 28


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> We should touch ESR register if only we have it.
> The patch fixes the problem mentoined here
> 
> 	http://lkml.org/lkml/2008/10/17/147
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> CC: Glauber Costa <glommer@gmail.com>

> -		apic_write(APIC_ESR, 0);
> -		apic_read(APIC_ESR);
> +		if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> +			apic_write(APIC_ESR, 0);
> +			apic_read(APIC_ESR);
> +		}

i'm wondering - is the server there really that old, that it has no 
integrated lapic? I.e. it's an i486 SMP box or so? Or perhaps some 
other, weird SMP box?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/