Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756471AbYJVO7o (ORCPT ); Wed, 22 Oct 2008 10:59:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756097AbYJVO73 (ORCPT ); Wed, 22 Oct 2008 10:59:29 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:33937 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755713AbYJVO72 (ORCPT ); Wed, 22 Oct 2008 10:59:28 -0400 Date: Wed, 22 Oct 2008 16:59:09 +0200 From: Ingo Molnar To: Cyrill Gorcunov Cc: Glauber Costa , LKML , "H. Peter Anvin" , Thomas Gleixner , "Maciej W. Rozycki" , Max Kellermann Subject: Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register Message-ID: <20081022145909.GA7224@elte.hu> References: <20081022140009.GA9639@localhost> <20081022141354.GA26372@elte.hu> <20081022141720.GB9639@localhost> <20081022142312.GC26372@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081022142312.GC26372@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0001] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 26 > > | > - apic_write(APIC_ESR, 0); > > | > - apic_read(APIC_ESR); > > | > + if (APIC_INTEGRATED(apic_version[phys_apicid])) { > > | > + apic_write(APIC_ESR, 0); > > | > + apic_read(APIC_ESR); > > | > + } this wouldnt build with certain configs: arch/x86/kernel/smpboot.c: In function 'do_boot_cpu': arch/x86/kernel/smpboot.c:897: error: 'phys_apicid' undeclared (first use in this function) arch/x86/kernel/smpboot.c:897: error: (Each undeclared identifier is reported only once arch/x86/kernel/smpboot.c:897: error: for each function it appears in.) include/asm/io_32.h: In function 'memcpy_fromio': because phys_apicid is not available in the !WAKE_SECONDARY_VIA_INIT case. Changed it to boot_cpu_physical_apicid - that should be good enough. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/