Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757233AbYJVQcz (ORCPT ); Wed, 22 Oct 2008 12:32:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756987AbYJVQcm (ORCPT ); Wed, 22 Oct 2008 12:32:42 -0400 Received: from vervifontaine.sonytel.be ([80.88.33.193]:62354 "EHLO vervifontaine.sonycom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751290AbYJVQcl (ORCPT ); Wed, 22 Oct 2008 12:32:41 -0400 Date: Wed, 22 Oct 2008 18:32:39 +0200 (CEST) From: Geert Uytterhoeven To: Phillip Lougher cc: akpm@linux-foundation.org, linux-embedded@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tim.bird@am.sony.com Subject: Re: Subject: [PATCH 01/16] Squashfs: inode operations In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-584349381-1983641362-1224693159=:5634" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 52 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---584349381-1983641362-1224693159=:5634 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/inode.c > +static int squashfs_new_inode(struct super_block *s, struct inode *i, > + struct squashfs_base_inode *inodeb) > +{ > + if (squashfs_get_id(s, le16_to_cpu(inodeb->uid), &i->i_uid) == 0) > + goto out; ^^^^^^^^ > + if (squashfs_get_id(s, le16_to_cpu(inodeb->guid), &i->i_gid) == 0) > + goto out; ^^^^^^^^ > + return 1; > + > +out: > + return 0; > +} As there's nothing to clean up, you can just use `return 0' instead of `goto out'. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 ---584349381-1983641362-1224693159=:5634-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/