Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756011AbYJWGoz (ORCPT ); Thu, 23 Oct 2008 02:44:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755519AbYJWGoq (ORCPT ); Thu, 23 Oct 2008 02:44:46 -0400 Received: from colo.lackof.org ([198.49.126.79]:46839 "EHLO colo.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754544AbYJWGop (ORCPT ); Thu, 23 Oct 2008 02:44:45 -0400 Date: Thu, 23 Oct 2008 00:44:12 -0600 From: Grant Grundler To: Matthew Wilcox Cc: Yinghai Lu , Grant Grundler , Jesse Barnes , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] pci: show dma_mask bits in /sys Message-ID: <20081023064412.GD31186@colo.lackof.org> References: <1223506943-6543-1-git-send-email-yinghai@kernel.org> <20081009211837.GC18444@colo.lackof.org> <48EE7745.2020603@kernel.org> <20081009213551.GC25780@parisc-linux.org> <86802c440810091451y4a3caceg1abaa75464c40a72@mail.gmail.com> <20081009225533.GB1914@colo.lackof.org> <48EE8E55.4000009@kernel.org> <20081012071157.GA20056@colo.lackof.org> <48FFD726.2010600@kernel.org> <20081023032833.GK26094@parisc-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081023032833.GK26094@parisc-linux.org> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 38 On Wed, Oct 22, 2008 at 09:28:33PM -0600, Matthew Wilcox wrote: > On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote: > > Grant prefer to add it /sys instead of showing in bootlog > > > > so could catch if the driver set the correct dma_mask. > > I still don't think this is useful information to be exposing. It's useful for anyone involved with device drivers - we agree that's a very limited subset of users. I certainly get fed up with trying to figure out which dma_mask each driver is using since in some cases it might vary depending on which HW is installed and which kernel is running. If the /sys patch added a PCI_DEBUG option to the kernel, would that work for you? I'm not keen on that but just looking for alternatives. Many other subsystems (SCSI, ACPI, PM, HID, ...) have a FOO_DEBUG option. Lastly, /sys seems to have over run even /proc. On an rx2600 (ia64): grundler@gsyprf3:/usr/src/linux-2.6$ find /sys ! -type d | wc 6288 6296 264893 grundler@gsyprf3:/usr/src/linux-2.6$ find /proc ! -type d | wc find: `/proc/tty/driver': Permission denied ... 4104 4104 100797 Pruning some of the crap out of there sounds like another task suitable for "kernel janitor" project. /me runs and hides :) thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/