Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081AbYJWGsi (ORCPT ); Thu, 23 Oct 2008 02:48:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753200AbYJWGs2 (ORCPT ); Thu, 23 Oct 2008 02:48:28 -0400 Received: from colo.lackof.org ([198.49.126.79]:46874 "EHLO colo.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbYJWGs1 (ORCPT ); Thu, 23 Oct 2008 02:48:27 -0400 Date: Thu, 23 Oct 2008 00:48:15 -0600 From: Grant Grundler To: Yinghai Lu Cc: Grant Grundler , Matthew Wilcox , Jesse Barnes , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] pci: show dma_mask bits in /sys Message-ID: <20081023064815.GE31186@colo.lackof.org> References: <1223506943-6543-1-git-send-email-yinghai@kernel.org> <20081009211837.GC18444@colo.lackof.org> <48EE7745.2020603@kernel.org> <20081009213551.GC25780@parisc-linux.org> <86802c440810091451y4a3caceg1abaa75464c40a72@mail.gmail.com> <20081009225533.GB1914@colo.lackof.org> <48EE8E55.4000009@kernel.org> <20081012071157.GA20056@colo.lackof.org> <48FFD726.2010600@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48FFD726.2010600@kernel.org> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1918 Lines: 60 On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote: > Grant prefer to add it /sys instead of showing in bootlog > > so could catch if the driver set the correct dma_mask. > > Signed-off-by: Yinghai Lu > > --- > drivers/pci/pci-sysfs.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > Index: linux-2.6/drivers/pci/pci-sysfs.c > =================================================================== > --- linux-2.6.orig/drivers/pci/pci-sysfs.c > +++ linux-2.6/drivers/pci/pci-sysfs.c > @@ -169,6 +169,21 @@ numa_node_show(struct device *dev, struc > #endif > > static ssize_t > +dma_mask_bits_show(struct device *dev, struct device_attribute *attr, char *buf) > +{ > + struct pci_dev *pdev = to_pci_dev(dev); > + > + return sprintf (buf, "%d\n", fls64(pdev->dma_mask)); Is there any reason to use %d instead of "0x%x" ? I'd much rather see this dumped in hex. > +} > + > +static ssize_t > +consistent_dma_mask_bits_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + return sprintf (buf, "%d\n", fls64(dev->coherent_dma_mask)); > +} > + > +static ssize_t > msi_bus_show(struct device *dev, struct device_attribute *attr, char *buf) > { > struct pci_dev *pdev = to_pci_dev(dev); > @@ -223,6 +238,8 @@ struct device_attribute pci_dev_attrs[] > #ifdef CONFIG_NUMA > __ATTR_RO(numa_node), > #endif > + __ATTR_RO(dma_mask_bits), > + __ATTR_RO(consistent_dma_mask_bits), > __ATTR(enable, 0600, is_enabled_show, is_enabled_store), > __ATTR(broken_parity_status,(S_IRUGO|S_IWUSR), > broken_parity_status_show,broken_parity_status_store), Otherwise looks good to me. thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/