Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbYJWIkA (ORCPT ); Thu, 23 Oct 2008 04:40:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753460AbYJWIj0 (ORCPT ); Thu, 23 Oct 2008 04:39:26 -0400 Received: from fxip-0047f.externet.hu ([88.209.222.127]:49838 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbYJWIjX (ORCPT ); Thu, 23 Oct 2008 04:39:23 -0400 To: penberg@cs.helsinki.fi CC: miklos@szeredi.hu, cl@linux-foundation.org, nickpiggin@yahoo.com.au, hugh@veritas.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org In-reply-to: <1224745831.25814.21.camel@penberg-laptop> (message from Pekka Enberg on Thu, 23 Oct 2008 10:10:31 +0300) Subject: Re: SLUB defrag pull request? References: <1223883004.31587.15.camel@penberg-laptop> <48FE6306.6020806@linux-foundation.org> <84144f020810221348j536f0d84vca039ff32676e2cc@mail.gmail.com> <1224745831.25814.21.camel@penberg-laptop> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: From: Miklos Szeredi Date: Thu, 23 Oct 2008 10:38:54 +0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 28 On Thu, 23 Oct 2008, Pekka Enberg wrote: > On Thu, 2008-10-23 at 00:10 +0200, Miklos Szeredi wrote: > > Actually, no: looking at the slub code it already makes sure that > > objects are neither poisoned, nor touched in any way _if_ there is a > > constructor for the object. And for good reason too, otherwise a > > reused object would contain rubbish after a second allocation. > > There's no inherent reason why we cannot poison slab caches with a > constructor. Right, it just needs to call the constructor for every allocation. > > Come on guys, you should be the experts in this thing! > > Yeah, I know. Yet you're stuck with us. That's sad. No, I was a bit rude, sorry. I think the _real_ problem is that instead of fancy features like this defragmenter, SLUB should first concentrate on getting the code solid enough to replace the other allocators. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/